Conversation
PR SummaryThis PR introduces configuration adjustments that refine the project's CI and dependency management. The workflow file (.github/workflows/integration.yaml) has been updated to remove the 'release-v1' branch from the list of triggers, ensuring that the CI pipeline only runs for the 'main' and 'prod' branches. Additionally, the dependency constraints for the 'kaleido' package in pyproject.toml have been tightened by limiting its version to less than 1.0.0. This helps enforce compatibility and prevent accidental upgrades to potentially breaking versions. Corresponding changes in the poetry.lock file (including an update to the autogenerated header and content hash) reflect these dependency modifications. Overall, these changes aim to improve configuration consistency and dependency safety without altering the core functionality of the application. Test Suggestions
|
2 participants
Pull Request Description
What and why?
⏺ Root Cause Found and Fixed
The issue was that Kaleido 1.0.0 is incompatible with Plotly 5.24.1. The CI logs showed:
Warning: You have Plotly version 5.24.1, which is not compatible with this version of Kaleido (1.0.0).
Please upgrade Plotly to version 6.1.1 or greater, or downgrade Kaleido to version 0.2.1.
Problem: The original constraint kaleido = ">=0.2.1,!=0.2.1.post1" allowed kaleido 1.0.0 to be installed in CI environments, but this version breaks compatibility with the current plotly version.
Solution: Updated the constraint to kaleido = ">=0.2.1,!=0.2.1.post1,<1.0.0" in pyproject.toml:25, which:
This ensures consistent kaleido 0.2.1 installation across all environments, maintaining compatibility with plotly 5.24.1.
How to test
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist